Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HyperlinkedRelatedField(view_name=) & HyperlinkedIdentityField(view_name=) param optional #530

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

Alexerson
Copy link
Contributor

@Alexerson Alexerson commented Jan 4, 2024

Fixes #537 537

@intgr intgr self-assigned this Mar 19, 2024
Copy link
Contributor

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some allowlist entries can be removed from scripts/stubtest/allowlist.txt

See failed job output in https://github.com/typeddjango/djangorestframework-stubs/actions/runs/8345359816/job/22840080240?pr=530

@intgr intgr changed the title Fix typing for HyperlinkedIdentityField Make HyperlinkedIdentityField.__init__(view_name=) param optional Mar 19, 2024
@intgr intgr changed the title Make HyperlinkedIdentityField.__init__(view_name=) param optional Make HyperlinkedIdentityField(view_name=) param optional Mar 19, 2024
Copy link
Contributor

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the late review. :)

@intgr intgr changed the title Make HyperlinkedIdentityField(view_name=) param optional Make HyperlinkedRelatedField(view_name=) & HyperlinkedIdentityField(view_name=) param optional Mar 19, 2024
@intgr intgr merged commit df9a89e into typeddjango:master Mar 19, 2024
12 checks passed
@Alexerson Alexerson deleted the fix-hyperlinked branch March 19, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Typing for classes inheriting HyperlinkedIdentityField
2 participants